Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Vector store abstractions hybrid search ADR #10196

Draft
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

westey-m
Copy link
Contributor

Motivation and Context

Create ADR for adding hybrid search support to the VectorStore abstractions.

Description

Adding hybrid ADR document

Contribution Checklist

@westey-m westey-m marked this pull request as draft January 15, 2025 15:34
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels Jan 20, 2025
@github-actions github-actions bot changed the title Vector store abstractions hybrid search ADR .Net: Vector store abstractions hybrid search ADR Jan 20, 2025
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @westey-m, here are some thoughts.

public string FusionMethod { get; init; } = null;

public VectorSearchFilter? Filter { get; init; }
public int Top { get; init; } = 3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continuing on the above, it may make sense to have an abstract base class for the common options (e.g. Top/Skip, which would seem to be a part of any search type). Though I'm not sure, and if we haven't captured such similarities via a base class it's not the end of the world either...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it would help a bit with implementation coding, where we want to pass the common options around. As you say though, it's not the end of the world. It shouldn't affect users.

… ability to select a target full text property though.
@roji
Copy link
Member

roji commented Mar 3, 2025

@westey-m is it intentional that this PR target main as opposed to the MEVD feature branch?

@westey-m
Copy link
Contributor Author

westey-m commented Mar 3, 2025

@westey-m is it intentional that this PR target main as opposed to the MEVD feature branch?

@roji, FYI this is just my working branch. The reviewed code is in this branch:
https://github.com/microsoft/semantic-kernel/tree/feature-keyword-hybrid-search

I haven't created a PR for that branch yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants