-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Vector store abstractions hybrid search ADR #10196
base: main
Are you sure you want to change the base?
Conversation
…n. Add property naming section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff @westey-m, here are some thoughts.
public string FusionMethod { get; init; } = null; | ||
|
||
public VectorSearchFilter? Filter { get; init; } | ||
public int Top { get; init; } = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Continuing on the above, it may make sense to have an abstract base class for the common options (e.g. Top/Skip, which would seem to be a part of any search type). Though I'm not sure, and if we haven't captured such similarities via a base class it's not the end of the world either...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it would help a bit with implementation coding, where we want to pass the common options around. As you say though, it's not the end of the world. It shouldn't affect users.
…ust have full text search enabled as agreed in review.
…ally if config is not set.
… ability to select a target full text property though.
@westey-m is it intentional that this PR target main as opposed to the MEVD feature branch? |
@roji, FYI this is just my working branch. The reviewed code is in this branch: I haven't created a PR for that branch yet. |
Motivation and Context
Create ADR for adding hybrid search support to the VectorStore abstractions.
Description
Adding hybrid ADR document
Contribution Checklist