Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: SK integration with MEAI Abstractions (Service Selector + Contents) Phase 1 #10651

Merged
merged 31 commits into from
Mar 3, 2025
Merged

.Net: SK integration with MEAI Abstractions (Service Selector + Contents) Phase 1 #10651

merged 31 commits into from
Mar 3, 2025

Conversation

RogerBarreto
Copy link
Member

@RogerBarreto RogerBarreto commented Feb 24, 2025 •
edited
Loading

Motivation and Context

This change adds a new IChatClientSelector abstraction to work without breaking current IAIServiceSelector implementations.

This was necessary because Kernel now will be able to resolve IChatClients which are not IAIService implementations, and OrderedAIServiceSelector now can select not only AIServices but ChatClients as well by implementing the IChatClientSelector interface.

All other changes are related to test accepting IChatClients added to the Service DI container, ensuring they work as expected together with current IChatCOmpletionService and ITextGenerationService in the Kernel.

@RogerBarreto RogerBarreto self-assigned this Feb 24, 2025
@RogerBarreto RogerBarreto added the .NET Issue or Pull requests regarding .NET code label Feb 24, 2025
@markwallace-microsoft markwallace-microsoft added kernel Issues or pull requests impacting the core kernel kernel.core labels Feb 26, 2025
@RogerBarreto RogerBarreto marked this pull request as ready for review February 26, 2025 19:56
@RogerBarreto RogerBarreto merged commit 908333b into microsoft:feature-msextensions-ai Mar 3, 2025
10 checks passed
@RogerBarreto RogerBarreto mentioned this pull request Mar 3, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub

@SergeyMenshykh SergeyMenshykh

@markwallace-microsoft markwallace-microsoft

@shethaadit shethaadit

@dmytrostruk dmytrostruk

Assignees

@RogerBarreto RogerBarreto

Labels
kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RogerBarreto @stephentoub @shethaadit @dmytrostruk @SergeyMenshykh @markwallace-microsoft