.Net: Add support for OpenAPI parameters defined with schema but without a type #10682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyMenshykh
added
.NET
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
westey-m
reviewed
Feb 25, 2025
dotnet/src/Functions/Functions.OpenApi/Serialization/OpenApiTypeConverter.cs
Show resolved
Hide resolved
westey-m
approved these changes
Feb 25, 2025
dmytrostruk
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation, Context and Description
Currently, the SK OpenAPI functionality supports operations with parameters defined by a schema that has a
typeproperty. If this property is not provided, which can happen if the schema is described using theanyOf,allOf, oroneOfkeywords, the execution of the operation with such parameters fails.This PR relaxes the OpenAPI parameters validation/conversion functionality by allowing parameters with no
typeproperty that has a valid schema or no schema at all.Fixes the "System.NotSupportedException: 'Unexpected type '' of parameter 'lat' with argument '37.7749'.'" mentioned in this issue: #10548