.Net: Allow HttpClient to be passed in for AzureOpenAI when building from s…

[strtdusty]

Allow HttpClient to be passed in for AzureOpenAI when building from service collection, just like it is from the Kernel Builder

Motivation and Context

Description

Add an optional HTTPClient to the extension methods and utilize it just like the kernel builder versions. Note that I don't think this is the proper way to handle things. It would likely be better to allow an optional client name to be sent in and then SK could/should use the client factory to fetch it. However, my change makes the interface consistent with what is already there.

Contribution Checklist

• [ X] The code builds clean without any errors or warnings
• [ X] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
• [X ] All unit tests pass, and I have added new tests where possible
• [ X] I didn't break anyone 😄

[strtdusty]

Note: I ran the build.cmd and it did flag API compatibility issues for the extension methods I am adding new optional parameters to. I could understand how this would create a binary incompatibility but I thought clients would get a new nuget package and rebuild? If this is a real incompatibility I could use some advice on fixing. I can't go the method overload route because the new and old method become ambiguous if the last parameter is not provided.

[strtdusty]

@microsoft-github-policy-service agree

[RogerBarreto]

@strtdusty Thanks for the contribution. This is welcomed, could you please add Unit Tests ensuring the behavior of the httpClient picking the one in the extension method and not the one in the IServiceColletion ?

I am adding new optional parameters to

That's fine, since you are adding the parameter to the end of the method, it is flagged as incompatibility but for a very niche scenario.

Regarding the ApiCompatibility you need to install the tool to generate the file automatically.

dotnet tool install --global Microsoft.DotNet.ApiCompat.Tool

Use the command below in the solution folder to generate the suppression file:

dotnet build -c Release /p:ApiCompatGenerateSuppressionFile=true

Thanks!

[strtdusty]

Tests updated, build passing locally with the API suppressions @RogerBarreto

[strtdusty]

Comments/test resolved

[strtdusty]

@RogerBarreto comments resolved. I think the PR is ready now.

[RogerBarreto]

For some obscure reason this PR says the maintainer allows edit the PR but I'm unable to help.

Getting

error: Authentication error: Authentication required: You must have push access to verify locks
error: failed to push some refs to 'https://github.com/strtdusty/semantic-kernel.git'

Anyways, update the order of the usings in the file test, and LGTM.

[strtdusty]

For some obscure reason this PR says the maintainer allows edit the PR but I'm unable to help.

Getting

error: Authentication error: Authentication required: You must have push access to verify locks
error: failed to push some refs to 'https://github.com/strtdusty/semantic-kernel.git'

Anyways, update the order of the usings in the file test, and LGTM.

@RogerBarreto it looks like your commit made it in to the PR so the usings are ordered.

[RogerBarreto]

I did through the github IDE but unfortunately doing this changed the encoding of the file, I will need you to pull the changes and save with the proper encoding and push a new commit

[strtdusty]

I did through the github IDE but unfortunately doing this changed the encoding of the file, I will need you to pull the changes and save with the proper encoding and push a new commit

Done