.Net: Upgrade dotnet sdk 9 #10716
Closed
.Net: Upgrade dotnet sdk 9 #10716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "image": "mcr.microsoft.com/devcontainers/universal:2", | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/node:1": {}, | ||
| "ghcr.io/devcontainers/features/dotnet:1": { | ||
| "version": "8" | ||
| "version": "9" |
There was a problem hiding this comment.
We are happy to add STS 9 as an additional sanity check, any 9 related instrumentation should be additional to existing 8. Giving that I would suggest adding both 8, and 9 containers as possibilities, and sticking with the 8 when not possible.
.github/workflows/dotnet-ci.yml
Outdated
| @@ -66,7 +68,7 @@ jobs: | |||
| matrix: | |||
| os: [windows-latest] | |||
| configuration: [Release, Debug] | |||
| dotnet-version: ['8.0.x'] | |||
| dotnet-version: ['8.0.x', '9.0.x'] | |||
There was a problem hiding this comment.
Might worth also explore adding the 9.0 port for the current projects.
<frameworks>net8.0;net9.0;netstandard2.0</frameworks>.
ross-p-smith
force-pushed
the
ross/dotnet9
branch
from
2c56ae9 to
e898928
Compare
markwallace-microsoft
added
.NET
ross-p-smith
had a problem deploying
to
integration
GitHub Actions
Failure
ross-p-smith
had a problem deploying
to
integration
GitHub Actions
Failure
markwallace-microsoft
removed
.NET
markwallace-microsoft
added
.NET
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
### Motivation and Context In sdk9, there is a bug fix to one of the analyzers: [https://github.com/dotnet/msbuild/issues/11426](https://github.com/dotnet/msbuild/issues/11426). This causes the code base to fail in the `dotnet format` stage when built on sdk9. This PR fixes the file that has been changed this week and adds a configuration into the build to format using sdk9.0 so that the build fails if more are introduced. - [x] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 This relates to #10716 and was previously fixed in #10741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Cloning the repo and following the dotnet NoteBook guide fails because it now requires .Net 9 SDK. This fixes #10715
Description
Contribution Checklist