Python: improved chat history samples #10737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
TaoChenOSU
reviewed
Feb 28, 2025
eavanvalkenburg
force-pushed
the
improve_chat_history_serialization_samples
branch
from
19540e2 to
6e076df
Compare
moonbox3
reviewed
Mar 3, 2025
eavanvalkenburg
force-pushed
the
improve_chat_history_serialization_samples
branch
3 times, most recently
from
d3e5260 to
148296c
Compare
TaoChenOSU
approved these changes
Mar 3, 2025
eavanvalkenburg
force-pushed
the
improve_chat_history_serialization_samples
branch
from
e7fc7b6 to
9cc69a0
Compare
moonbox3
approved these changes
Mar 4, 2025
rracanicci
pushed a commit
to rracanicci/semantic-kernel
that referenced
this pull request
Mar 5, 2025
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Improve the serialization sample Added a more complex sample for using ChatHistory with a VectorStore to store in a backend. Also improves the typing of the vectorstoremodel decorator ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Improve the serialization sample
Added a more complex sample for using ChatHistory with a VectorStore to store in a backend.
Also improves the typing of the vectorstoremodel decorator
Description
Contribution Checklist