.Net: dotnet format issues with SDK 9.0 #10741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
ross-p-smith
had a problem deploying
to
integration
GitHub Actions
Error
ross-p-smith
temporarily deployed
to
integration
GitHub Actions
Inactive
ross-p-smith
force-pushed
the
ross/dotnet9_build_fixes
branch
from
eec70a8 to
4895399
Compare
westey-m
approved these changes
Mar 3, 2025
ross-p-smith
force-pushed
the
ross/dotnet9_build_fixes
branch
from
4895399 to
813c32c
Compare
RogerBarreto
approved these changes
Mar 4, 2025
markwallace-microsoft
approved these changes
Mar 4, 2025
rracanicci
pushed a commit
to rracanicci/semantic-kernel
that referenced
this pull request
Mar 5, 2025
### Motivation and Context In order to be able to build the dotnet code with version 9 SDK, there were some problems with the following file `/workspaces/semantic-kernel/dotnet/src/InternalUtilities/src/Diagnostics/ActivityExtensions.cs`. This had a BOM encoding problem which was causing `dotnet format` to fail. As seen in this Issue [https://github.com/dotnet/sdk/issues/46780](https://github.com/dotnet/sdk/issues/46780). I fixed the encoding and formatting issues ready for version 9. Most of the formatting issues are around removing the access modifiers on interface members This relates to microsoft#10715 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
### Motivation and Context In sdk9, there is a bug fix to one of the analyzers: [https://github.com/dotnet/msbuild/issues/11426](https://github.com/dotnet/msbuild/issues/11426). This causes the code base to fail in the `dotnet format` stage when built on sdk9. This PR fixes the file that has been changed this week and adds a configuration into the build to format using sdk9.0 so that the build fails if more are introduced. - [x] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 This relates to #10716 and was previously fixed in #10741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In order to be able to build the dotnet code with version 9 SDK, there were some problems with the following file
/workspaces/semantic-kernel/dotnet/src/InternalUtilities/src/Diagnostics/ActivityExtensions.cs. This had a BOM encoding problem which was causingdotnet formatto fail. As seen in this Issue dotnet/sdk#46780.I fixed the encoding and formatting issues ready for version 9. Most of the formatting issues are around removing the access modifiers on interface members
This relates to #10715
Description
Contribution Checklist