Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Concept Samples Updates and Fixes #10746

Merged
merged 9 commits into from
Mar 4, 2025
Merged

.Net: Concept Samples Updates and Fixes #10746

merged 9 commits into from
Mar 4, 2025

Conversation

RogerBarreto
Copy link
Member

  • Applied updates to existing samples closer to the new guidelines
  • Removed LocalModel failing samples and relocated to ChatCompletion specific to LMStudio and Ollama.
  • Updated description and ensured all samples are working with latest versions.

@RogerBarreto RogerBarreto self-assigned this Mar 2, 2025
@RogerBarreto RogerBarreto requested a review from a team as a code owner March 2, 2025 18:12
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Mar 2, 2025
@markwallace-microsoft markwallace-microsoft removed the kernel Issues or pull requests impacting the core kernel label Mar 2, 2025
@westey-m
Copy link
Contributor

westey-m commented Mar 3, 2025

@RogerBarreto, remember to update the README with the file name changes.

@RogerBarreto Microsoft Teams for GitHub
Copy link
Member Author

Good point, will do that.

@RogerBarreto RogerBarreto added this pull request to the merge queue Mar 4, 2025
Merged via the queue into microsoft:main with commit b07ce3d Mar 4, 2025
19 checks passed
@RogerBarreto RogerBarreto deleted the update-demo-localmodels branch March 4, 2025 11:47
rracanicci pushed a commit to rracanicci/semantic-kernel that referenced this pull request Mar 5, 2025
@RogerBarreto @rracanicci
.Net: Concept Samples Updates and Fixes (microsoft#10746)
127f415 
- Applied updates to existing samples closer to the new guidelines
- Removed `LocalModel` failing samples and relocated to `ChatCompletion`
specific to `LMStudio` and `Ollama`.
- Updated description and ensured all samples are working with latest
versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyMenshykh SergeyMenshykh

@westey-m westey-m

Assignees

@RogerBarreto RogerBarreto

Labels
documentation .NET Issue or Pull requests regarding .NET code
Projects
Semantic Kernel
Status: Sprint: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RogerBarreto @westey-m @SergeyMenshykh @markwallace-microsoft