Python: Don't store AzureAIInferenceChatCompletion response inner_content inside of item's text content #10747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…item's text content
moonbox3
changed the title
markwallace-microsoft
added
the
python
Python Test Coverage Report •
Python Unit Test Overview
|
||||||||||||||||||||||||||||||
eavanvalkenburg
approved these changes
Mar 3, 2025
markwallace-microsoft
approved these changes
Mar 3, 2025
musale
pushed a commit
to musale/semantic-kernel
that referenced
this pull request
Mar 10, 2025
…tent inside of item's text content (microsoft#10747) ### Motivation and Context The `AzureAIInferenceChatCompletion` class, during `_create_chat_message_content` creation, is storing the `response` which is a non-hashable object. In other connectors, like the `AzureChatCompletion` we do not store the `response` in the CMC's TextContent item. The `response` is available as part of the main `ChatMessageContent` that is returned, so we don't need to store this twice, especially since as part of agent group chat, we need to be able to get the inner item's hash for message comparison. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description Remove the call to store the response as the item's inner_content here: ```python items.append( TextContent( text=choice.message.content, # inner_content=response, <--- removed metadata=metadata, ) ) ``` - Closes microsoft#10722 <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
AzureAIInferenceChatCompletionclass, during_create_chat_message_contentcreation, is storing theresponsewhich is a non-hashable object. In other connectors, like theAzureChatCompletionwe do not store theresponsein the CMC's TextContent item. Theresponseis available as part of the mainChatMessageContentthat is returned, so we don't need to store this twice, especially since as part of agent group chat, we need to be able to get the inner item's hash for message comparison.Description
Remove the call to store the response as the item's inner_content here:
Contribution Checklist