Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Allow OpenAIAssistant model id to pass into setup resources #10748

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

moonbox3
Copy link
Contributor

@moonbox3 moonbox3 commented Mar 3, 2025

Motivation and Context

With the updated OpenAIAssistantAgent.setup_resources method, we weren't allowing one to pass in the ai_model_id as part of the method. This PR fixes that.

Description

PR fixes the setup_resources method to be able to override the chat_deployment_name as part of the OpenAISettings ai_model_id config.

Contribution Checklist

@moonbox3 moonbox3 requested a review from a team as a code owner March 3, 2025 03:45
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Mar 3, 2025
@github-actions github-actions bot changed the title Allow model id to pass into setup resources Python: Allow model id to pass into setup resources Mar 3, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Mar 3, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/agents/open_ai
   open_ai_assistant_agent.py185697%216, 229, 265, 435, 526, 614
TOTAL19018238087% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3199 5 💤 0 ❌ 0 🔥 1m 35s ⏱️

@moonbox3 moonbox3 changed the title Python: Allow model id to pass into setup resources Python: Allow OpenAIAssistant model id to pass into setup resources Mar 3, 2025
@moonbox3 moonbox3 enabled auto-merge March 3, 2025 11:06
@moonbox3 moonbox3 added this pull request to the merge queue Mar 3, 2025
Merged via the queue into microsoft:main with commit 3a799c8 Mar 3, 2025
28 checks passed
@moonbox3 moonbox3 deleted the openai-asst-model branch March 3, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants