Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: SK integration with MEAI Abstractions #10754

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RogerBarreto
Copy link
Member

@RogerBarreto RogerBarreto commented Mar 3, 2025

WORK IN PROGRESS - DRAFT PR FOR UPDATE FEATURE BRANCH

This PR will leave Draft once all the feature is ready to merge into main.

…nts) Phase 1 (#10651)

### Motivation and Context

- Resolves partially #10319 

This change adds a new `IChatClientSelector` abstraction to work without
breaking current `IAIServiceSelector` implementations.

This was necessary because `Kernel` now will be able to resolve
`IChatClient`s which are not `IAIService` implementations, and
`OrderedAIServiceSelector` now can select not only `AIServices` but
`ChatClients` as well by implementing the `IChatClientSelector`
interface.

All other changes are related to test accepting `IChatClient`s added to
the `Service` DI container, ensuring they work as expected together with
current `IChatCOmpletionService` and `ITextGenerationService` in the
`Kernel`.
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Mar 3, 2025
@RogerBarreto RogerBarreto changed the title .Net: SK integration with MEAI Abstractions .Net: SK integration with MEAI Abstractions (Main Sync) - WIP Mar 3, 2025
@github-actions github-actions bot changed the title .Net: SK integration with MEAI Abstractions (Main Sync) - WIP .Net: SK integration with MEAI Abstractions Mar 3, 2025
@RogerBarreto RogerBarreto self-assigned this Mar 3, 2025
@RogerBarreto RogerBarreto added the PR: in progress Under development and/or addressing feedback label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: in progress Under development and/or addressing feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants