Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary: [regression] Trouble work in headless mode #18473

Closed
Zeroes1 opened this issue Jan 29, 2025 · 6 comments
Closed

Canary: [regression] Trouble work in headless mode #18473

Zeroes1 opened this issue Jan 29, 2025 · 6 comments
Assignees
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.

Comments

@Zeroes1
Copy link

Zeroes1 commented Jan 29, 2025

Windows Terminal version

1.23.10282.0

Windows build number

10.0.19045.5371

Other Software

No response

Steps to reproduce

set WT work in background mode it's turn ON with settings.json with option:
"compatibility.allowHeadless": true,

Expected Behavior

under version
terminal-1.23.3101.0
..
terminal-1.23.3461.0

start WT
close WT by method:
a) click mouse on cross window (or press alt-f4)
b) use hotkey for close panel - ctrl-shift-w

after this in process exist only:
WindowsTerminal.exe

Actual Behavior

under version
terminal-1.23.3481.0
..
terminal-1.23.10282.0

after close panel in process exist:
WindowsTerminal.exe
and child process:
OpenConsole.exe

(if use default profile for run PowerShell)

if use profile for run Far Manager
after close WT in process exist:
WindowsTerminal.exe
and child process:
OpenConsole.exe
Far.exe

if 10 times start WT and 10 time close panel
we get:
one process WindowsTerminal.exe
10 process OpenConsole.exe
10 process Far.exe

@Zeroes1 Zeroes1 added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 29, 2025
@carlos-zamora carlos-zamora changed the title Canary: [regression] Trouble work in background mode? Canary: [regression] Trouble work in headless mode Jan 29, 2025
@carlos-zamora carlos-zamora added this to the Terminal v1.23 milestone Jan 29, 2025
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Area-Windowing Window frame, quake mode, tearout and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 29, 2025
@Zeroes1
Copy link
Author

Zeroes1 commented Feb 2, 2025

Additional information:

  1. If try close last window WT with internal command: ( exit [+ enter] for powershell/cmd, F10 for Far Manager)
    the associated processes [OpenConsole.exe + powershell.exe/cmd.exe/Far.exe] will be closed normally.

  2. when close last window WT (with ANY method)
    process WindowsTerminal.exe (headlesses) start showing the application icon on the taskbar (in terminal-1.23.3461.0 or earlier without this effect)

Image

@Zeroes1
Copy link
Author

Zeroes1 commented Feb 21, 2025

@lhecker any idea? [pls check also #18497]

@lhecker
Copy link
Member

lhecker commented Feb 21, 2025

I haven't worked on this yet because I'm working on another project internally right now. I have promised though to fix the bugs I caused sometime soon, maybe next week. :)

@lhecker
Copy link
Member

lhecker commented Feb 24, 2025

I cannot reproduce this issue. I tried:

  • Enable headless mode
  • Open the first window with 1 tab
  • Ctrl+Shift+W
  • --> No processes leaked

What did I do wrong?

The good news is that I did find another bug thanks to you which I'll fix soon.

@Zeroes1
Copy link
Author

Zeroes1 commented Feb 26, 2025

@lhecker what you version check?

latest canary terminal-1.24.551.0 already without this problem (issue 18497 gone too)
terminal-1.24.531.0 - latest with problem (from 22 feb)

@lhecker
Copy link
Member

lhecker commented Feb 26, 2025

Oh, so the issue is gone now? Did I understand you correctly? Let me know if I got it wrong. 🙂
In that case it was probably fixed by #18621. Thank you for the report!

@lhecker lhecker closed this as completed Feb 26, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants