Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag tab into new window lost all panels besides the first #18572

Closed
Rodrigodd opened this issue Feb 13, 2025 · 1 comment · Fixed by #18627
Closed

Drag tab into new window lost all panels besides the first #18572

Rodrigodd opened this issue Feb 13, 2025 · 1 comment · Fixed by #18627
Assignees
@lhecker
Labels
Area-Windowing Window frame, quake mode, tearout In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal.

Comments

@Rodrigodd
Copy link

Windows Terminal version

Preview 1.23.10353.0

Windows build number

10.0.22631.0

Other Software

No response

Steps to reproduce

Create two tabs. In the second one split the screen in two panels. Drag this second tab into a new window.

Expected Behavior

The new window will have both panels. Terminal 1.21.10351.0 works as expected.

Actual Behavior

The new window have only the terminal in the first panel. From the task explorer, the processes in the lost panels doesn't become detach, they are just killed.
@Rodrigodd Rodrigodd added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 13, 2025
@Rodrigodd Rodrigodd changed the title Drag tab into new windows lost all panels besides the first Drag tab into new window lost all panels besides the first Feb 13, 2025
@zadjii-msft
Copy link
Member

oh dear, yep that's pretty bad. Thanks for filing!

@zadjii-msft zadjii-msft added the Area-Windowing Window frame, quake mode, tearout label Feb 13, 2025
@lhecker lhecker added Priority-1 A description (P1) Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 25, 2025
@lhecker lhecker mentioned this issue Feb 25, 2025
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Feb 25, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Feb 26, 2025
DHowett pushed a commit that referenced this issue Feb 26, 2025
@lhecker @DHowett
Fix panes being dropped when tearing off tabs (#18627)
e9520c0 
I don't actually know why this is happening, because it doesn't
happen with startup actions specified in the settings file.
In any case, it's fixed with more delays.

Closes #18572

## Validation Steps Performed
* Create a tab with 2 panes
* Tear it off into a new window
* New window has 1 tab with 2 panes ✅

(cherry picked from commit e1b28e7)
Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgXTsJY PVTI_lADOAF3p4s4AxadtzgXsQ6w
Service-Version: 1.23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhecker lhecker

Labels
Area-Windowing Window frame, quake mode, tearout In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix panes being dropped when tearing off tabs microsoft/terminal
3 participants
@lhecker @zadjii-msft @Rodrigodd