All URL hovers (OSC 8 and autodetected) are off by 0.5 cells #18595
Assignees
Labels
Area-Interaction
Interacting with the vintage console window (as opposed to driving via API or hooks)
Impact-Correctness
It be wrong.
Impact-Visual
It look bad.
In-PR
This issue has a related PR
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Needs-Tag-Fix
Doesn't match tag requirements
Product-Terminal
The new Windows Terminal.
Milestone
Comments
DHowett
added
Issue-Bug
|
Related to #18486 |
carlos-zamora
added
Area-Interaction
DHowett
pushed a commit
that referenced
this issue
Feb 26, 2025
…mode (#18602) Missed a few `_getTerminalPosition()` on the first run. Disabled rounding for pointer movements and mouse wheel events (which are used for hyperlink hover detection and vt mouse mode). The only time we round now is... - `SetEndSelectionPoint()` --> because we're updating a selection - `ControlCore->LeftClickOnTerminal()` --> where all paths are used for selection* *the only path that doesn't is `RepositionCursorWithMouse` being enabled, which also makes sense based on clicking around Notepad with a large font size. ## References and Relevant Issues Follow-up for #18486 Closes #18595 ## Validation Steps Performed In large font size, play around with midnight commander and hover over hyperlink edges.
microsoft-github-policy-service
bot
added
the
Needs-Tag-Fix
DHowett
pushed a commit
that referenced
this issue
Feb 26, 2025
…mode (#18602) Missed a few `_getTerminalPosition()` on the first run. Disabled rounding for pointer movements and mouse wheel events (which are used for hyperlink hover detection and vt mouse mode). The only time we round now is... - `SetEndSelectionPoint()` --> because we're updating a selection - `ControlCore->LeftClickOnTerminal()` --> where all paths are used for selection* *the only path that doesn't is `RepositionCursorWithMouse` being enabled, which also makes sense based on clicking around Notepad with a large font size. ## References and Relevant Issues Follow-up for #18486 Closes #18595 ## Validation Steps Performed In large font size, play around with midnight commander and hover over hyperlink edges. (cherry picked from commit e5b972a) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgXgv1c Service-Version: 1.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Windows Terminal version
1.23 Preview, 1.24 Canary
Windows build number
No response
Other Software
No response
Steps to reproduce
Hyperlink. Hover it.
Expected Behavior
No response
Actual Behavior
The text was updated successfully, but these errors were encountered: