Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft::Console::VirtualTerminal::StateMachine::ProcessString Crash #18598

Open
carlos-zamora opened this issue Feb 19, 2025 · 1 comment · May be fixed by #18632
Open

Microsoft::Console::VirtualTerminal::StateMachine::ProcessString Crash #18598

carlos-zamora opened this issue Feb 19, 2025 · 1 comment · May be fixed by #18632
Labels
Area-Quality Stability, Performance, Etc. In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news.
Milestone
Terminal v1.24

Comments

@carlos-zamora
Copy link
Member

Internal ADO link: https://microsoft.visualstudio.com/OS/_workitems/edit/54447014?src=WorkItemMention&src-action=artifact_link

Getting a good amount of crashes for Germanium on v1.21/22/23
@carlos-zamora carlos-zamora added Area-Quality Stability, Performance, Etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news. labels Feb 19, 2025
@carlos-zamora carlos-zamora added this to the Terminal v1.24 milestone Feb 19, 2025
@github-project-automation github-project-automation bot moved this to To Cherry Pick in 1.22 Servicing Pipeline Feb 19, 2025
@github-project-automation github-project-automation bot moved this to To Cherry Pick in 1.21 Servicing Pipeline Feb 19, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 19, 2025
@lhecker
Copy link
Member

lhecker commented Feb 25, 2025 •
edited
Loading

I looked at this one and it appears as if we have a lifetime issue where something calls into the renderer while it's already partially (or entirely? impossible to tell) deallocated. We need to check our renderer management in ControlCore, including callbacks, timers, etc.

@lhecker lhecker linked a pull request Feb 26, 2025 that will close this issue
Open
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Feb 26, 2025
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Quality Stability, Performance, Etc. In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news.
Projects
1.21 Servicing Pipeline
Status: To Cherry Pick
1.22 Servicing Pipeline
Status: To Cherry Pick
Milestone
Terminal v1.24
Development

Successfully merging a pull request may close this issue.

Fix a shutdown race condition in ControlCore microsoft/terminal
2 participants
@lhecker @carlos-zamora