Bugfix: don't round to nearest cell for mouse movements and VT mouse mode #18602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
DHowett
reviewed
Feb 20, 2025
| @@ -340,7 +340,7 @@ namespace winrt::Microsoft::Terminal::Control::implementation | |||
| const Core::Point pixelPosition, | |||
| const bool pointerPressedInBounds) | |||
| { | |||
| const auto terminalPosition = _getTerminalPosition(til::point{ pixelPosition }, true); | |||
| const auto terminalPosition = _getTerminalPosition(til::point{ pixelPosition }, false); | |||
There was a problem hiding this comment.
Ah, I see why this is confusing. I was wondering how this change didn't impact selection. This variable is defined early and used late.... and selection ignores it. Wow.
DHowett
approved these changes
Feb 20, 2025
microsoft-github-policy-service
bot
requested review from
zadjii-msft,
PankajBhojwani,
DHowett and
lhecker
lhecker
approved these changes
Feb 26, 2025
microsoft-github-policy-service
bot
removed
the
Needs-Second
DHowett
pushed a commit
that referenced
this pull request
Feb 26, 2025
…mode (#18602) Missed a few `_getTerminalPosition()` on the first run. Disabled rounding for pointer movements and mouse wheel events (which are used for hyperlink hover detection and vt mouse mode). The only time we round now is... - `SetEndSelectionPoint()` --> because we're updating a selection - `ControlCore->LeftClickOnTerminal()` --> where all paths are used for selection* *the only path that doesn't is `RepositionCursorWithMouse` being enabled, which also makes sense based on clicking around Notepad with a large font size. ## References and Relevant Issues Follow-up for #18486 Closes #18595 ## Validation Steps Performed In large font size, play around with midnight commander and hover over hyperlink edges. (cherry picked from commit e5b972a) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgXgv1c Service-Version: 1.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Missed a few
_getTerminalPosition()on the first run. Disabled rounding for pointer movements and mouse wheel events (which are used for hyperlink hover detection and vt mouse mode). The only time we round now is...SetEndSelectionPoint()--> because we're updating a selectionControlCore->LeftClickOnTerminal()--> where all paths are used for selection**the only path that doesn't is
RepositionCursorWithMousebeing enabled, which also makes sense based on clicking around Notepad with a large font size.References and Relevant Issues
Follow-up for #18486
Closes #18595
Validation Steps Performed
In large font size, play around with midnight commander and hover over hyperlink edges.