Fix persistence of the last closed window #18623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DHowett
approved these changes
Feb 24, 2025
Comment on lines
761
to
762
| const auto globalSettings = _app.Logic().Settings().GlobalSettings(); | ||
| const auto windowLimit = globalSettings.ShouldUsePersistedLayout() ? 1 : 0; |
There was a problem hiding this comment.
is it important that we keep the logic here separate from _shouldSkipClosingWindows?
There was a problem hiding this comment.
You mean I should just call _shouldSkipClosingWindows in this function?
There was a problem hiding this comment.
Hmm I'm a little hesitant to do that, because I'm currently very unhappy with this approach and I don't want to codify this weird dependency. As an example, it doesn't consider the existence of the quake window right now.
There was a problem hiding this comment.
My gut feeling was correct. This PR is completely broken. 😅
carlos-zamora
approved these changes
Feb 24, 2025
DHowett
approved these changes
Feb 26, 2025
DHowett
pushed a commit
that referenced
this pull request
Feb 26, 2025
lhecker
added a commit
that referenced
this pull request
Feb 27, 2025
lhecker
added a commit
that referenced
this pull request
Feb 28, 2025
The logic didn't work when persistence was enabled and you had 2 windows and closed the 2nd one, or when dragging the last tab out of the only window. ## Validation Steps Performed * 2 windows, close the 2nd one, app doesn't exit ✅ * 1 window, 1 tab, drag the tab out of the window, app doesn't exit ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin.
Closes #18525
Validation Steps Performed