Fix two sources of runtime exceptions #18628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
DHowett
approved these changes
Feb 25, 2025
carlos-zamora
approved these changes
Feb 25, 2025
DHowett
pushed a commit
that referenced
this pull request
Feb 26, 2025
* `_ApplyLanguageSettingChange` calls `PrimaryLanguageOverride` (the WinRT API function) and we would call it every time a new window is created. Now it's only called on settings load. * `_RegisterTabEvents` would listen for "Content" changes which can be null. `IVector::Append` throws if a null object is given. In our case, it's null if the content got erased with nothing. Additionally, this fixes a bug where we wouldn't call `_ProcessLazySettingsChanges` on startup. This is important if the settings file was changed while Windows Terminal wasn't running. Lastly, there's a lifetime fix in this PR, which is a one-line change and I didn't want to make a separate PR for that. (cherry picked from commit ff9664d) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgXsQ60 Service-Version: 1.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_ApplyLanguageSettingChangecallsPrimaryLanguageOverride(the WinRT API function) and we would call it every time a new
window is created. Now it's only called on settings load.
_RegisterTabEventswould listen for "Content" changes which canbe null.
IVector::Appendthrows if a null object is given.In our case, it's null if the content got erased with nothing.
Additionally, this fixes a bug where we wouldn't call
_ProcessLazySettingsChangeson startup. This is important if thesettings file was changed while Windows Terminal wasn't running.
Lastly, there's a lifetime fix in this PR, which is a one-line change
and I didn't want to make a separate PR for that.