Reduce log spam on conhost exit #18629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Product-Conhost
lhecker
commented
Feb 25, 2025
| cbOutBufferSize, | ||
| &cbWritten, | ||
| nullptr)); | ||
| RETURN_IF_WIN32_BOOL_FALSE_EXPECTED(DeviceIoControl( |
There was a problem hiding this comment.
This one in particular is redundant with the log calls in all the other existing places. It's IMO not very interesting to see a message stating that DeviceIoControl failed, if the caller then logs the returned HRESULT again. The caller signature gives much more information IMO (source and type of the call).
DHowett
approved these changes
Feb 25, 2025
DHowett
pushed a commit
that referenced
this pull request
Feb 26, 2025
When the server handle gets closed on conhost (= terminal is gone), and e.g. PowerShell is used, we would previously log 6 error messages. This PR reduces it to zero, by removing the 3 biggest offenders. (cherry picked from commit 0df8268) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgXsQ64 Service-Version: 1.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the server handle gets closed on conhost (= terminal is gone),
and e.g. PowerShell is used, we would previously log 6 error messages.
This PR reduces it to zero, by removing the 3 biggest offenders.