fix inconsistent patch size in dofa huge model #2627
Merged
+25
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
adamjstewart
added
the
backwards-incompatible
adamjstewart
approved these changes
Mar 9, 2025
|
Not too worried about breaking backwards compatibility here since the previous huge model definition never worked. Should be ready to go now, thanks again for reporting this bug! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the inconsistent patch size of DOFA huge model, specifically:
docs/api/models.rst:.. autofunction:: dofa_huge_patch16_224, changed to autofunction:: dofa_huge_patch14_224
tests/models/test_dofa.py: dofa_huge_patch16_224, changed to dofa_huge_patch14_224
tests/models/test_dofa.py: dofa_huge_patch16_224() changed to dofa_huge_patch14_224()
torchgeo/models/init.py: dofa_huge_patch16_224, changed to dofa_huge_patch14_224
torchgeo/models/init.py: 'dofa_huge_patch16_224', changed to dofa_huge_patch14_224
torchgeo/models/dofa.py: def dofa_huge_patch16_224(*args: Any, **kwargs: Any) -> DOFA: changed to dofa_huge_patch14_224(*args: Any, **kwargs: Any)
Closes #2618