-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding string to end of union used for content-type header results in error #2853
Comments
In responses:
|
|
@markcowl discuss with DPG and then file impl issues |
@markcowl do we have an impl issue for this? And do you know what sprint it is planned for? |
Hi @markcowl - Any updates on when this will be addressed? We have a service where this issue will block the release of this service: Azure/azure-rest-api-specs#25168 (comment) |
@swathipil This service spec has been merged. |
thanks @markcowl! We merged the spec, but added a TODO comment in the spec to address the issue as soon as the fix for this is in. We're still blocked from releasing any SDKs generated by this spec until this issue is addressed. |
Hi @markcowl - We're blocked from releasing our SDKs by this issue (as per comment above), and we plan on releasing this upcoming release week. Do you know when this will be addressed? |
I believe what was decided is that the way to do so was to specify a wildcard content type and that Now do client emitter actually support that is another question. |
We were able to test out the scenario that we believed would have been blocking, and it passed. Can confirm that this is non-blocking. Thanks @timotheeguerin! |
Link to repro in playground [here].
In SchemaRegistry, we want to the content type header to be a union of values. This does not compile when
string
is added to the end of the union, and fails with:It works when
string;
on line 66 of the playground link above is removed. However, it should work when string is added to the end. It also works when the header is renamed to something else, so it seems to be a bug with using the"Content-Type"
header specifically.May be related to #2727
The text was updated successfully, but these errors were encountered: