Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this casting is unfortunate, we should probably rethink how we want this to look #3701

Open
JoshLove-msft opened this issue Jun 28, 2024 · 2 comments
Open

this casting is unfortunate, we should probably rethink how we want this to look #3701

JoshLove-msft opened this issue Jun 28, 2024 · 2 comments
Assignees
@JoshLove-msft
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@JoshLove-msft
Copy link
Contributor 

          this casting is unfortunate, we should probably rethink how we want this to look

Originally posted by @m-nash in #3698 (comment)
@JoshLove-msft JoshLove-msft self-assigned this Jun 28, 2024
@JoshLove-msft JoshLove-msft added emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp and removed needs-area labels Jun 28, 2024
@JoshLove-msft JoshLove-msft mentioned this issue Jun 28, 2024
Merged
@JoshLove-msft
Copy link
Contributor Author

This is no longer an issue as we collapsed the plugin and abstractions back into single dll.

@JoshLove-msft JoshLove-msft reopened this Jul 10, 2024
@JoshLove-msft
Copy link
Contributor Author

This will be an issue if we expose a public Instance property on the base plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshLove-msft JoshLove-msft

Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshLove-msft