Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override Write method in SingleLineCommentStatement #6136

Closed
JoshLove-msft opened this issue Feb 25, 2025 · 0 comments · Fixed by #6141
Closed

Override Write method in SingleLineCommentStatement #6136

JoshLove-msft opened this issue Feb 25, 2025 · 0 comments · Fixed by #6141
Assignees
@JoshLove-msft
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@JoshLove-msft
Copy link
Contributor

JoshLove-msft commented Feb 25, 2025 •
edited
Loading

Currently we don't override Write so nothing gets written. We should also consider making Write in MethodBodyStatement abstract, so that this doesn't come up with other types.
@JoshLove-msft JoshLove-msft added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Feb 25, 2025
@JoshLove-msft JoshLove-msft self-assigned this Feb 25, 2025
@JoshLove-msft JoshLove-msft mentioned this issue Feb 25, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 25, 2025
@JoshLove-msft
Write comment statement (#6141)
e0cf97c 
Fixes #6136

Also make MethodBodyStatement.Write `abstract`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshLove-msft JoshLove-msft

Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Write comment statement JoshLove-msft/typespec
1 participant
@JoshLove-msft