Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression from upgrading to TCGC that retired SerializedName #6187

Closed
JoshLove-msft opened this issue Feb 27, 2025 · 0 comments · Fixed by #6188
Closed

Regression from upgrading to TCGC that retired SerializedName #6187

JoshLove-msft opened this issue Feb 27, 2025 · 0 comments · Fixed by #6188
Assignees
@JoshLove-msft
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@JoshLove-msft
Copy link
Contributor

JoshLove-msft commented Feb 27, 2025 •
edited
Loading

Previously, we would use the SerializedName from the InputModelProperty which would always be populated. It looks like in the latest TCGC, we needed to coalesce with InputModelProperty.Name, but we didn't update the behavior in CanonicalTypeProvider.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshLove-msft JoshLove-msft

Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue where serialized name is not correctly set for custom properties JoshLove-msft/typespec
1 participant
@JoshLove-msft