Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

questions about versioning mutator #6198

Open
tadelesh opened this issue Feb 28, 2025 · 1 comment
Open

questions about versioning mutator #6198

tadelesh opened this issue Feb 28, 2025 · 1 comment

Comments

@tadelesh
Copy link
Member

if an interface is deleted from a version, when i call mutateSubgraph with this version's mutator for this interface, what should i get? current behavior seems that i could get this interface, but with previous projection, i will get Intrinsic type. is it by design or a bug?

@timotheeguerin
Copy link
Member

timotheeguerin commented Feb 28, 2025

hhm I guess I didn't expect you to use the mutator that way. In theory the mutator should have removed all reference to this interface vs with projection it would convert it to never and that would remove it.

You have to be careful when using mutateSubgraph as it does partial mutation(by design or everytime you'd do you'd be mutating the entire graph, this means things like namespace will not point to the new realm but the original, types that are not mutated as well will be the original and their parent will point back to the original). This means that for versioning you do want a full mutation and should just call mutateSubgraphWithNamespace on the service namespac to mutate everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants