-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
questions about versioning mutator #6198
Comments
hhm I guess I didn't expect you to use the mutator that way. In theory the mutator should have removed all reference to this interface vs with projection it would convert it to never and that would remove it. You have to be careful when using |
for this example, how could i know |
it wouldn't be in the containing namespace. THe way you are meant to use versioning projection or mutator is to do a full projection/mutation and just look at the projected/mutated data structure. You don't project/mutate go back and forth. |
after i use |
Everything referenced there will be mutated expect the compiler types. The expected behavior is the first thing you do is mutate for the version you care about, then you traverse the graph returned(lose any reference to the original for that version) look at openapi or autorest implementation We are about to remove projection this month, probably this or next month or week, this is a hard requirement for 1.0-rc, please get this solved asap. I will remove Tcgc from the build if needs be. |
talked with @iscai-msft which I think we found a way to move forward. I'll file a separate issue to discuss expanding the versioning api so you can get reference of types mutated which can allow for a bigger picture representation. But this is something that would be potentially quite prone to misuse so we'll have to be careful. |
if an interface is deleted from a version, when i call
mutateSubgraph
with this version's mutator for this interface, what should i get? current behavior seems that i could get this interface, but with previous projection, i will getIntrinsic
type. is it by design or a bug?The text was updated successfully, but these errors were encountered: