Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IDE] Improve Library Completion resolving all installed Cadl packages and optimize #622

Closed
Jg1255 opened this issue Jun 13, 2022 · 4 comments
Closed

[IDE] Improve Library Completion resolving all installed Cadl packages and optimize #622

Jg1255 opened this issue Jun 13, 2022 · 4 comments
Milestone
Backlog

Comments

@Jg1255
Copy link
Contributor

Jg1255 commented Jun 13, 2022

There should be an implementation so that Library Completion only includes Cadl libraries.
@ghost ghost added the Needs Triage label Jun 13, 2022
@markcowl
Copy link
Contributor

markcowl commented Jun 13, 2022 •
edited
Loading

@Jg1255 Is this in import statements? Note that imports are explicitly defined to be able to include '.js' files.

@timotheeguerin timotheeguerin mentioned this issue Jun 13, 2022
Closed
@timotheeguerin timotheeguerin changed the title Improve Library Completion to only include Cadl libraries [IDE] Improve Library Completion to only include Cadl libraries Jun 13, 2022
@timotheeguerin
Copy link
Member

This is a split of the Import completion task #275 for which @Jg1255 made the 1st iteration that complete with the available cadl libraries. This would be the 3rd part which looks into resolving the list from all installed packages regardless of them being in dependencies and peerDependencies and optimiuze to reduce the file system calls.

@nguerrera
Copy link
Contributor

Maybe the bug title could be improved. I'm having a hard time mapping that to "only include Cadl libraries"

@timotheeguerin timotheeguerin changed the title [IDE] Improve Library Completion to only include Cadl libraries [IDE] Improve Library Completion resolving all installed cadl packages and optimize Jun 13, 2022
@timotheeguerin timotheeguerin changed the title [IDE] Improve Library Completion resolving all installed cadl packages and optimize [IDE] Improve Library Completion resolving all installed Cadl packages and optimize Jun 13, 2022
@markcowl markcowl added this to the [2022] July milestone Jun 16, 2022
@markcowl markcowl added the 📌 label Jun 16, 2022
@markcowl markcowl modified the milestones: [2022] July, [2022] August Jul 7, 2022
@markcowl markcowl assigned Jg1255 and unassigned Jg1255 Sep 13, 2022
@markcowl markcowl modified the milestones: [2022] September, Backlog Sep 13, 2022
@timotheeguerin
Copy link
Member

This I think is completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@bterlson @nguerrera @timotheeguerin @markcowl @Jg1255