Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve language server file system cache #894

Open
nguerrera opened this issue Aug 19, 2022 · 0 comments
Open

Improve language server file system cache #894

nguerrera opened this issue Aug 19, 2022 · 0 comments
Labels
ide Issues for VS, VSCode, Monaco, etc.
Milestone

Comments

@nguerrera
Copy link
Contributor

nguerrera commented Aug 19, 2022

We use the file watching mechanism provided by LSP and cache to avoid repeated I/O. But it doesn't currently prevent us from hitting the disk to do realpath a lot or from stat'ing directories, etc. Profiling in #868 show that this is significant and can eat up > 90% of the time in a language server call on an up-to-date program.

That said this isn't high priority. While the amount of time spent in I/O is very significant relative to an up-to-date program (after #868), it isn't likely to be noticeable. It is overall a small amount of time, it's just nearly all that we do when the program is up to date. It probably makes sense to wait for a case where this is perceptible before adding complexity to go after these final milliseconds. I suspect you will need a lot of files/libraries pulled in by your project before you can notice it.

@ghost ghost added the Needs Triage label Aug 19, 2022
@nguerrera nguerrera added this to the Backlog milestone Aug 26, 2022
@timotheeguerin timotheeguerin added the ide Issues for VS, VSCode, Monaco, etc. label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ide Issues for VS, VSCode, Monaco, etc.
Projects
None yet
Development

No branches or pull requests

2 participants