-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test plan for TypeSpec extension #5552
base: main
Are you sure you want to change the base?
Conversation
deb90af
to
f01671f
Compare
Create image Add files via upload Update create-typespec-project-test-plan.md Create generate-client-code-from-typespec-test-plan.md Add files via upload Update generate-client-code-from-typespec-test-plan.md Create generate-openapi3-from-typespec-test-plan.md Add files via upload Update generate-openapi3-from-typespec-test-plan.md Update generate-openapi3-from-typespec-test-plan.md Create generate-server-stub-from-typespec-test-plan.md Add files via upload Update generate-server-stub-from-typespec-test-plan.md Add files via upload Create import-typespec-from-openapi3-test-plan.md
Update generate-server-stub-from-typespec-test-plan.md Update create-typespec-project-test-plan.md Create typespec-extension-basic-features-test-plan.md Add files via upload Update typespec-extension-basic-features-test-plan.md Update typespec-extension-basic-features-test-plan.md Add files via upload Update create-typespec-project-test-plan.md Update generate-client-code-from-typespec-test-plan.md Update generate-openapi3-from-typespec-test-plan.md Add files via upload Update generate-server-stub-from-typespec-test-plan.md Update import-typespec-from-openapi3-test-plan.md Update create-typespec-project-test-plan.md Update generate-client-code-from-typespec-test-plan.md Update generate-openapi3-from-typespec-test-plan.md Add files via upload Update generate-client-code-from-typespec-test-plan.md Add files via upload Update typespec-extension-basic-features-test-plan.md Update typespec-extension-basic-features-test-plan.md Update generate-client-code-from-typespec-test-plan.md Update generate-openapi3-from-typespec-test-plan.md Update create-typespec-project-test-plan.md Add files via upload Update generate-openapi3-from-typespec-test-plan.md
@microsoft-github-policy-service agree company="Microsoft" |
packages/typespec-vscode/test/manual/create-typespec-project-test-plan.md
Outdated
Show resolved
Hide resolved
packages/typespec-vscode/test/manual/create-typespec-project-test-plan.md
Outdated
Show resolved
Hide resolved
packages/typespec-vscode/test/manual/create-typespec-project-test-plan.md
Outdated
Show resolved
Hide resolved
packages/typespec-vscode/test/manual/create-typespec-project-test-plan.md
Outdated
Show resolved
Hide resolved
packages/typespec-vscode/test/manual/typespec-extension-basic-features-test-plan.md
Outdated
Show resolved
Hide resolved
packages/typespec-vscode/test/manual/import-typespec-from-openapi3-test-plan.md
Outdated
Show resolved
Hide resolved
packages/typespec-vscode/test/manual/generate-client-code-from-typespec-test-plan.md
Outdated
Show resolved
Hide resolved
packages/typespec-vscode/test/manual/generate-openapi3-from-typespec-test-plan.md
Outdated
Show resolved
Hide resolved
I think some of the concern is that's a lot of image for a git repo that might need to be updated as the test plan change |
@msyyc , could you help to double check the images to see whether all of them are necessary for vender to follow to do the test? Timothee has a point that images have a higher maintain cost, so it's good if we can simplify the images but still make sure the doc is good enough for venders to follow to test the features. thanks. After these user experience in UX is stabilized, we will expect any changes in these UX in the future should contains the corresponding change in these manual test plan (just like updating auto test for feature update now) and go through a manual test sign-off by venders which should also be helpful to make sure the doc is up-to-date. thanks. |
Got it. |
Is it also not possible to automate this instead |
we are doing some investigation into the auto-test for it as @msyyc mentioned. It will depend on the investigation result and how frequently these UX will be changed later to determine whether we want to add auto UI test (I have dealt with UI test a lot when in Sql which is actually painful to maintain because of its instability in nature). Before that, manual test would help to cover these user experience in vscode. thanks. |
I think the major concern is that this repo is the core repo for typespec and a test document does not seem to belong. If we need to check a test plan into someplace, I would suggest some other repo (perhaps typespec-azure-pr). This just does not seem like it is of general interest to consumers of typespec, so does not seem to belong in the repo |
Update: after optimization, we reduce the image number used by docs from 80 to 55. |
I think we should call them "manual test cases" instead of "test plan" which would be more accurate. They are actually the same as automated test in logic if we don't look at the implementation (code/doc) and execution engine (machine/people). And a few detail reasons why I would prefer them to be along with the code:
thx |
packages/typespec-vscode/test/manual/generate-from-typespec-test-plan.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talking with the team
- this is still a lot of images which when I look at it provide very little value but add size to this repo, they just show basic vscode UI and folder structure which could just be very well be described with a few words and be easier to maintain
- manual test are still a nightmare to deal with and put a lof of extra work on us as well
- There is already quite a few prs in progress that are changing things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually we are making some progress in the ui-automation and we may go to that approach directly. A quick question, does our CI machine have UI? or are we able to have some machine with UI in CI so that we will be able to run these UI test in CI? thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't the ui run headless, windows is super slow in ci and Linux doesn't.
None of the other ui test we have have any issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are these ui test? We would like to have a look into them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is 2(3 if you include the azure repo)
- packages/playground-website
test:e2e
script that runs playwright - packages/typespec-vscode itself that runs the basic browser smoke test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, thx! @msyyc , could you help to double check these tests and see whether there is anything our ui-test can leverage? thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/vitest-dev/vscode/tree/main/test-e2e vitest vscode extension also has a bunch of ui test, also running with playwright+ vitest
fix #5444
Description
Added four test scenarios test plan to TypeSpec Extension:
@RodgeFu and @msyyc for notification.