[typespec-vscode] Rename file should rename import #5674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzhongl524
requested review from
RodgeFu,
bterlson,
markcowl,
allenjzhang,
timotheeguerin and
witemple-msft
as code owners
RodgeFu
reviewed
Jan 21, 2025
RodgeFu
reviewed
Feb 3, 2025
RodgeFu
reviewed
Feb 3, 2025
RodgeFu
reviewed
Feb 3, 2025
RodgeFu
reviewed
Feb 3, 2025
RodgeFu
reviewed
Feb 3, 2025
RodgeFu
reviewed
Feb 3, 2025
RodgeFu
reviewed
Feb 3, 2025
.chronus/changes/rename-file-should-rename-import-2025-2-25-16-22-53.md
Outdated
Show resolved
Hide resolved
…/mzhongl524/typespec into rename-file-should-rename-import
|
@RodgeFu @mzhongl524 updated the PR, adding more test, fixing multiple folder move scenarios and simplifying things a little |
RodgeFu
reviewed
Apr 28, 2025
RodgeFu
reviewed
Apr 28, 2025
RodgeFu
reviewed
Apr 28, 2025
RodgeFu
reviewed
Apr 28, 2025
@timotheeguerin , thanks for helping to update. Sorry that I am working on another urgent project and don't have much time on TypeSpec IDE recently. I have added some small comments and talked with @mzhongl524 about them who will help to update. Feel free to let us know if you have any more feedback. thanks. |
|
@timotheeguerin please help review |
timotheeguerin
approved these changes
Apr 30, 2025
chrisradek
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #2470
Compiler:
Locate the file with the modified import content and modify it
Typespec-vscode:
Add implementation code such as configuration content and user-friendly operations