Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce IPC between ts part and C# part to report diagnostics and write logs #5917

Merged
merged 32 commits into from
Feb 26, 2025

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Feb 10, 2025

Fixes #5920

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Feb 10, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 10, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

@typespec/http-client-csharp

This reverts commit 25cf9b5.
@ArcturusZhang ArcturusZhang changed the title Some attempts to introduce IPC between ts part and C# part to report diagnostics and write logs introduce IPC between ts part and C# part to report diagnostics and write logs Feb 18, 2025
@ArcturusZhang
Copy link
Member Author

@JoshLove-msft this should also contribute to this change despite it has merged: #5904
In general we should avoid to introduce such complicated logic in our emitter, and it would be more straight forward to figure this out in the generator

Copy link
Contributor

@JoshLove-msft JoshLove-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we introduce a minimal E2E test?

@ArcturusZhang
Copy link
Member Author

Can we introduce a minimal E2E test?

I updated the SamplePlugin project, now when you generate a spec using the sample plugin, it would give you information such like this:
image

@ArcturusZhang ArcturusZhang added this pull request to the merge queue Feb 26, 2025
Merged via the queue into microsoft:main with commit c6ae78e Feb 26, 2025
21 checks passed
@ArcturusZhang ArcturusZhang deleted the some-trials-on-jsonrpc branch February 26, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[http-client-csharp] The generator should report any error/warning/information back to the emitter
3 participants