Drop support for node 18, make engine install strict and add missing node 22 to linux test ci #5977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timotheeguerin
commented
Feb 12, 2025
•
timotheeguerin
commented
- fix Remove support for node18 #6095 make node 20 minimum version(preparation for 1.0-rc)
- install with strict engine to catch dependency that might not support a version of node we support
- add missing CI branch: node 22 on linux
timotheeguerin
requested review from
bterlson,
markcowl,
allenjzhang,
witemple-msft,
chrisradek and
AlitzelMendez
as code owners
mikeharder
approved these changes
Feb 12, 2025
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
timotheeguerin
changed the title
chrisradek
approved these changes
Mar 5, 2025
markcowl
approved these changes
Mar 5, 2025
allenjzhang
approved these changes
Mar 5, 2025
|
Beat Chris to it. :-) |
github-merge-queue bot
pushed a commit
to Azure/typespec-azure
that referenced
this pull request
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.