[core] Empty parameter visibility and visibility string deprecation

[witemple-msft]

• Makes the necessary core/http changes to deprecate
  • parameterVisibility/returnTypeVisibility with no arguments.
  • use of string visibility modifiers.
  • LegacyParameterVisibility HTTP flag.
• Deprecations are raised as warnings visibility-legacy and will be converted to errors in 1.0-rc.
• Numerous tests and samples have been updated to replace use of string visibility modifiers with Lifecycle modifiers.
• Deprecation messages for deprecated APIs have been updated to indicate that they will be REMOVED in 1.0-rc.
• Added PatchOptions/getPatchOptions which now controls Visibility.Patch.

WIP:

• Replace uses of string-based visibility modifiers throughout Azure specs with Lifecycle modifiers (required to avoid breaking the specs repo).
• Replace uses of empty parameter visibility constraints throughout Azure Specs with PatchOptions.
• Remove uses of deprecated visibility analysis methods throughout Azure TypeSpec libraries/emitters (can be done between now and 1.0-rc if not before the next release).

[azure-sdk]

❌ There is undocummented changes. Run chronus add to add a changeset or click here.

The following packages have changes but are not documented.

• ❌@typespec/http-client-csharp

The following packages have already been documented:

• ✅ @typespec/compiler
• ✅ @typespec/http-specs
• ✅ @typespec/http
• ✅ @typespec/openapi
• ✅ @typespec/rest

Show changes

@typespec/compiler - deprecation ✏️

Deprecate use of string-based visibility modifiers using warnings.,> ,> String-based visibilities can be replaced as follows:,> ,> - "create", "read", "update", "delete", and "query" can be replaced with Lifecycle.Create, Lifecycle.Read, Lifecycle.Update, Lifecycle.Delete, and Lifecycle.Query respectively.,> - @visibility("none") can be replaced with @invisible(Lifecycle).,> ,> For example:,> ,> tsp,> @visibility("create", "read"),> example: string;,> ,> ,> can be replaced with:,> ,> tsp,> @visibility(Lifecycle.Create, Lifecycle.Read),> example: string;,> ,> ,> tsp,> @visibility("none"),> example: string;,> ,> ,> can be replaced with:,> ,> tsp,> @invisible(Lifecycle),> example: string;,> ,> ,> Additionally, @parameterVisibility with no arguments is deprecated.,> ,> tsp,> @parameterVisibility,> @patch,> op example(@bodyRoot resource: Resource): Resource;,> ,> ,> The effect of @parameterVisibility is to disable effective PATCH optionality. If you wish,> to disable effective PATCH optionality in @typespec/http, preventing it from treating all,> properties of the request body as effectively optional, you can now do so explicitly:,> ,> tsp,> @patch(#{ implicitOptionality: false }),> op example(@bodyRoot resource: Resource): Resource;,>

@typespec/http-specs - internal ✏️

Replace use of string-based visibility modifiers with enum-based Lifecycle modifiers in tests.

@typespec/http - internal ✏️

Replace use of string-based visibility modifiers with enum-based Lifecycle modifiers in tests.

@typespec/rest - internal ✏️

Replace use of string-based visibility modifiers with enum-based Lifecycle modifiers in tests.

@typespec/openapi - internal ✏️

Remove references to string-based visibility from function documentation.

[azure-sdk]

You can try these changes here

🛝 Playground	🌐 Website	🛝 VSCode Extension

[witemple-msft]

Azure companion PR: Azure/typespec-azure#2263