Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Initial check-in for supporting telemetry in vscode #6123

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
some update
  • Loading branch information
RodgeFu committed Feb 24, 2025
commit 43b59abe68e96307cc024b55a57f54945969a512
4 changes: 1 addition & 3 deletions packages/typespec-vscode/src/extension.ts
Original file line number Diff line number Diff line change
@@ -92,9 +92,7 @@ export async function activate(context: ExtensionContext) {
if (client && client.state === State.Running) {
tel.lastStep = "Restart LSP client";
await client.restart();
return client.state === State.Running
? { code: ResultCode.Success, value: client }
: { code: ResultCode.Fail, details: "TspLanguageClient is not running." };
return { code: ResultCode.Success, value: client };
} else {
logger.info(
"TypeSpec LSP server is not running which is not expected, try to recreate and start...",
2 changes: 1 addition & 1 deletion packages/typespec-vscode/src/tsp-executable-resolver.ts
Original file line number Diff line number Diff line change
@@ -80,7 +80,7 @@ export async function resolveTypeSpecServer(
if (serverPath) {
logger.info(`Server path loaded from TypeSpec extension configuration: ${serverPath}`);
telemetryClient.logOperationDetailTelemetry(activityId, {
compilerLocation: "configured-compiler",
compilerLocation: "compiler-configured-by-setting",
});
} else {
logger.info(
Loading
Oops, something went wrong.