Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Initial check-in for supporting telemetry in vscode #6123

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add vsix to artifact
  • Loading branch information
RodgeFu committed Feb 27, 2025
commit b056e298268bf19384df90ea271be0004db241cb
24 changes: 12 additions & 12 deletions eng/tsp-core/pipelines/jobs/build-for-publish.yml
Original file line number Diff line number Diff line change
@@ -73,22 +73,22 @@ jobs:

templateContext:
outputs:
- output: pipelineArtifact
path: $(Build.ArtifactStagingDirectory)/npm-packages-stable
artifact: npm-packages-stable
displayName: Publish npm stable packages(.tgz) as pipeline artifacts
# - output: pipelineArtifact
# path: $(Build.ArtifactStagingDirectory)/npm-packages-stable
# artifact: npm-packages-stable
# displayName: Publish npm stable packages(.tgz) as pipeline artifacts

- output: pipelineArtifact
path: $(Build.ArtifactStagingDirectory)/npm-packages-next
artifact: npm-packages-next
displayName: Publish npm next packages(.tgz) as pipeline artifacts
# - output: pipelineArtifact
# path: $(Build.ArtifactStagingDirectory)/npm-packages-next
# artifact: npm-packages-next
# displayName: Publish npm next packages(.tgz) as pipeline artifacts

- output: pipelineArtifact
path: $(Build.ArtifactStagingDirectory)/vscode-extension
artifact: vscode-extension-unsigned
displayName: Publish VSCode extension(.vsix) as pipeline artifacts

- output: pipelineArtifact
path: $(Build.ArtifactStagingDirectory)/vs-extension
artifact: vs-extension-unsigned
displayName: Publish VS extension(.vsix) as pipeline artifacts
# - output: pipelineArtifact
# path: $(Build.ArtifactStagingDirectory)/vs-extension
# artifact: vs-extension-unsigned
# displayName: Publish VS extension(.vsix) as pipeline artifacts
Original file line number Diff line number Diff line change
@@ -38,7 +38,9 @@ class TelemetryClient {
private getConnectionString(): string | undefined {
let key: string | undefined = pkgJson.telemetryKey;
if (!key || key === EmptyGuid) {
// try to check environment variable VSCODE_TELEMETRY_KEY if the key is not provided in package.json
logger.debug(
"Telemetry key is not provided in package.json, try to use environment variable VSCODE_TELEMETRY_KEY",
);
key = process.env.VSCODE_TELEMETRY_KEY;
}
if (!key || key === EmptyGuid) {
Loading
Oops, something went wrong.