-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use value syntax for @header
, and add explode option
#6130
Conversation
All changed packages have been documented.
Show changes
|
You can try these changes here
|
Updates to address microsoft/typespec#4114 Depends on: microsoft/typespec#6130 --------- Co-authored-by: Christopher Radek <Christopher.Radek@microsoft.com>
/** | ||
* The string format of the array. "csv" and "simple" are used interchangeably, as are | ||
* "multi" and "form". | ||
* @deprecated use explode and `@encode` decorator instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timotheeguerin @chrisradek hello I'd like to comfirm two questions here:
- would this deprecation happen in our March GA scope, I mean any
format
usage in typespec or compiler interface would be removed and not supported? - for header parameter except
explode
option do we allow to customizeallowReserved
option for header value also?
/cc @qiaozha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is being removed. And no what does it mean for header param allow reserve tells uri template you can include / and other uri reserved char this makes not sense for header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The format option wasn't used a single time before in the spec repos, so you have some problem with a spec?
Fixes #4114
One question is whether to add a new http-specs test for the explode scenarios as part of this PR. Currently there aren't any specs for headers defined as objects - I presume since swagger doesn't allow it.
Related typespec-azure PR: Azure/typespec-azure#2257