Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-client-java, support (non-nested) continuationToken for unbranded #6143

Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
8f04696
fix interface
weidongxu-microsoft Feb 14, 2025
25e05d0
test code and initial interface of PageableContinuationToken
weidongxu-microsoft Feb 14, 2025
f7a0c45
handle PagedResponse
weidongxu-microsoft Feb 18, 2025
224703c
handle query/header
weidongxu-microsoft Feb 18, 2025
03d005c
hack for test
weidongxu-microsoft Feb 19, 2025
928ab36
Merge branch 'main' into http-client-java_continuation-token
weidongxu-microsoft Feb 20, 2025
32137b1
refactor to use ModelPropertySegment, instead of itemName/itemSeriali…
weidongxu-microsoft Feb 20, 2025
3785ba3
hide continuationToken parameter from API
weidongxu-microsoft Feb 20, 2025
d2c8831
add throw calls on not support items in PagingOptions
weidongxu-microsoft Feb 20, 2025
18f8ae0
Merge branch 'main' into http-client-java_continuation-token
weidongxu-microsoft Feb 25, 2025
feb1c68
use tcgc for continuationToken
weidongxu-microsoft Feb 25, 2025
a6cb649
Merge branch 'main' into http-client-java_continuation-token
weidongxu-microsoft Feb 25, 2025
c168edd
enable for unbranded
weidongxu-microsoft Feb 25, 2025
0cd5416
fix
weidongxu-microsoft Feb 25, 2025
9ce5472
bump http-specs and regen
weidongxu-microsoft Feb 25, 2025
905abfe
update test
weidongxu-microsoft Feb 25, 2025
d9924ae
test
weidongxu-microsoft Feb 25, 2025
c85e84d
fix
weidongxu-microsoft Feb 25, 2025
c6b7a2c
comment
weidongxu-microsoft Feb 25, 2025
59e1d38
add test for page2
weidongxu-microsoft Feb 25, 2025
c6d3eb3
revert Main
weidongxu-microsoft Feb 25, 2025
4aa4b0f
bump jar
weidongxu-microsoft Feb 25, 2025
6af2a02
bump version
weidongxu-microsoft Feb 25, 2025
9d81f37
test for throws if non-supported param is set
weidongxu-microsoft Feb 25, 2025
e15b44e
fix test package ref
weidongxu-microsoft Feb 25, 2025
df60efe
Merge branch 'main' into http-client-java_continuation-token
weidongxu-microsoft Feb 27, 2025
77b4d3c
0.1.12
weidongxu-microsoft Feb 27, 2025
cbf31a6
review feedback
weidongxu-microsoft Feb 28, 2025
87491a1
simplify paged op logic, do early return
weidongxu-microsoft Feb 28, 2025
77234d1
Merge branch 'main' into http-client-java_continuation-token
weidongxu-microsoft Feb 28, 2025
34f4cb6
Fix typo in comment: "mutally" to "mutually"
weidongxu-microsoft Mar 4, 2025
89b3638
Merge branch 'main' into http-client-java_continuation-token
weidongxu-microsoft Mar 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
weidongxu-microsoft committed Feb 25, 2025
commit 0cd5416c1a09eb1efe412f9abcd8c1f48288b049
13 changes: 11 additions & 2 deletions packages/http-client-java/emitter/src/code-model-builder.ts
Original file line number Diff line number Diff line change
@@ -1063,8 +1063,17 @@ export class CodeModelBuilder {
if (parameter && op.parameters) {
for (const param of op.parameters) {
if (param.protocol.http?.in === parameter.kind) {
continuationTokenParameter = param;
break;
if (
parameter.kind === "header" &&
param.language.default.serializedName.toLowerCase() ===
parameter.serializedName.toLowerCase()
) {
continuationTokenParameter = param;
break;
} else if (param.language.default.serializedName === parameter.serializedName) {
continuationTokenParameter = param;
break;
}
}
}
}
Loading
Oops, something went wrong.