-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Not Ready] [typespec-vs/typespec-vscode] Optimize err msg in typsespc extension #6144
base: main
Are you sure you want to change the base?
[Not Ready] [typespec-vs/typespec-vscode] Optimize err msg in typsespc extension #6144
Conversation
…xtension in an environment without Node.js
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
You can try these changes here
|
please create PRs as draft if they are not ready to review(make sure to do it before creating it so everybody is not added as a reviewer) |
@@ -159,6 +159,7 @@ export class TspLanguageClient { | |||
logger.error( | |||
[ | |||
`TypeSpec server executable was not found: '${this.exe.command}' is not found. Make sure either:`, | |||
" - Node.js is installed locally and available in PATH.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we can know the command is "node", please update to only add the line when the command is "node". thx
this.exe.command === "node" | ||
? [ | ||
`TypeSpec server executable was not found: '${this.exe.command}' is not found. Make sure either:`, | ||
" - Node.js is installed locally and available in PATH.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to have the ..?.. : .. here to make the code more clean. Same comment for above
Fix: #5667
Optimize the error messages that appear when using TypeSpec VS Code Extension in an environment without Node.js