[Not Ready] [typespec-vs/typespec-vscode] Optimize err msg in typsespc extension #6144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtension in an environment without Node.js
mzhongl524
requested review from
RodgeFu,
bterlson,
markcowl,
allenjzhang,
timotheeguerin,
chrisradek and
AlitzelMendez
as code owners
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
|
You can try these changes here
|
|
please create PRs as draft if they are not ready to review(make sure to do it before creating it so everybody is not added as a reviewer) |
RodgeFu
reviewed
Feb 27, 2025
| @@ -159,6 +159,7 @@ export class TspLanguageClient { | |||
| logger.error( | |||
| [ | |||
| `TypeSpec server executable was not found: '${this.exe.command}' is not found. Make sure either:`, | |||
| " - Node.js is installed locally and available in PATH.", | |||
There was a problem hiding this comment.
i think we can know the command is "node", please update to only add the line when the command is "node". thx
RodgeFu
reviewed
Mar 1, 2025
| this.exe.command === "node" | ||
| ? [ | ||
| `TypeSpec server executable was not found: '${this.exe.command}' is not found. Make sure either:`, | ||
| " - Node.js is installed locally and available in PATH.", |
There was a problem hiding this comment.
it's better to have the ..?.. : .. here to make the code more clean. Same comment for above
RodgeFu
reviewed
Mar 3, 2025
| ); | ||
| const msg = [ | ||
| `TypeSpec server executable was not found: '${this.exe.command}' is not found. Make sure either:`, | ||
| ...(this.exe.command === "node" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #5667
Optimize the error messages that appear when using TypeSpec VS Code Extension in an environment without Node.js