Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAPI 3 Emitter] Reuse Operation IDs With Identical Values In @OperationId Decorators For Shared Routes #6157

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

wanlwanl
Copy link
Member

Fix: #5513

This pull request introduces changes to reuse operation IDs when all @operationId decorators share the same value, which improve the usability for client code generation to leverage the shared operation ID.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 26, 2025

All changed packages have been documented.

  • @typespec/openapi3
Show changes

@typespec/openapi3 - feature ✏️

Shared operations operationId can now be set if they all share the same value provided by @operationId

typo

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 26, 2025

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@timotheeguerin
Copy link
Member

e2e test just seems to be failing the playground tests

Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
@wanlwanl wanlwanl enabled auto-merge February 28, 2025 03:41
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@wanlwanl wanlwanl added this pull request to the merge queue Feb 28, 2025
Merged via the queue into microsoft:main with commit 134f7e7 Feb 28, 2025
24 checks passed
@wanlwanl wanlwanl deleted the wanl/opid branch February 28, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: sharedRoute openapi operationId issue
4 participants