Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the client-namespace-conflict diagnostic #6161

Merged

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Feb 26, 2025

Fixes Azure/autorest.csharp#5241

I removed the report diagnostic in our emitter - because not every generator would have this issue
and move the diagnostic reporting into our C# generator, when we build the namespace for a client type.

I also added a few test cases for the Emitter class in our C# generator, which leads to series of other changes about the disposing issue.

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Feb 26, 2025
@ArcturusZhang ArcturusZhang force-pushed the namespace-diagnostic-update branch from 694d17a to 07c774f Compare February 26, 2025 10:02
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@ArcturusZhang ArcturusZhang marked this pull request as ready for review February 27, 2025 07:25
@ArcturusZhang ArcturusZhang added this pull request to the merge queue Mar 3, 2025
Merged via the queue into microsoft:main with commit 4abea21 Mar 3, 2025
21 checks passed
@ArcturusZhang ArcturusZhang deleted the namespace-diagnostic-update branch March 3, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autorest.csharp should not report the @typespec/http-client-csharp/client-namespace-conflict diagnostic
3 participants