Refine the client-namespace-conflict diagnostic
#6161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
ArcturusZhang
force-pushed
the
namespace-diagnostic-update
branch
from
694d17a to
07c774f
Compare
|
API change check API changes are not detected in this pull request. |
…ype deserialization, which might be incorrect. Will change it later
ArcturusZhang
commented
Feb 27, 2025
...nt-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ClientProvider.cs
Show resolved
Hide resolved
ArcturusZhang
commented
Feb 27, 2025
packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/EmitterRpc/Emitter.cs
Outdated
Show resolved
Hide resolved
ArcturusZhang
commented
Feb 27, 2025
packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/EmitterRpc/Emitter.cs
Outdated
Show resolved
Hide resolved
ArcturusZhang
commented
Feb 27, 2025
...ges/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Shared/StringExtensions.cs
Show resolved
Hide resolved
ArcturusZhang
requested review from
m-nash,
JoshLove-msft and
jorgerangel-msft
as code owners
ArcturusZhang
commented
Feb 27, 2025
packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/CodeModelPlugin.cs
Outdated
Show resolved
Hide resolved
ArcturusZhang
commented
Feb 27, 2025
packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/EmitterRpc/Emitter.cs
Show resolved
Hide resolved
ArcturusZhang
commented
Feb 27, 2025
...es/http-client-csharp/generator/Microsoft.TypeSpec.Generator/test/TestHelpers/MockHelpers.cs
Show resolved
Hide resolved
6 tasks
packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/perf/PluginInitializer.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/StartUp/PluginHandler.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/StartUp/PluginHandler.cs
Outdated
Show resolved
Hide resolved
JoshLove-msft
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Azure/autorest.csharp#5241
I removed the report diagnostic in our emitter - because not every generator would have this issue
and move the diagnostic reporting into our C# generator, when we build the namespace for a client type.
I also added a few test cases for the
Emitterclass in our C# generator, which leads to series of other changes about the disposing issue.