Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the client-namespace-conflict diagnostic #6161

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add a comment to explain the situation
  • Loading branch information
ArcturusZhang committed Mar 3, 2025
commit ebd9acc479706e2fff02fd8c5ba38008e1afd9fe
Original file line number Diff line number Diff line change
@@ -151,6 +151,8 @@ public ClientProvider(InputClient inputClient)
private const string namespaceConflictCode = "client-namespace-conflict";

private string? _namespace;
// This `BuildNamespace` method has been called twice - one when building the `Type`, the other is trying to find the CustomCodeView, both of them are required.
// therefore here to avoid this being called twice because this method now reports a diagnostic, we cache the result.
protected override string BuildNamespace() => _namespace ??= BuildNamespaceCore();

private string BuildNamespaceCore()
Loading
Oops, something went wrong.