Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the client-namespace-conflict diagnostic #6161

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean up
  • Loading branch information
ArcturusZhang committed Feb 27, 2025
commit ed2947a9767d887e0dd8759aa0dee7af38a53d96
1 change: 0 additions & 1 deletion packages/http-client-csharp/emitter/src/lib/lib.ts
Original file line number Diff line number Diff line change
@@ -63,7 +63,6 @@ const diags: { [code: string]: DiagnosticDefinition<DiagnosticMessages> } = {
"client-namespace-conflict": {
severity: "warning",
messages: {
// default: paramMessage`namespace ${"clientNamespace"} conflicts with client ${"clientName"}, please use @clientName to specify a different name for the client.`,
default: paramMessage`${"message"}`,
},
},
Original file line number Diff line number Diff line change
@@ -27,7 +27,6 @@ private void SendNotification(string method, object content)
var paramsContent = JsonSerializer.Serialize(content);
var message = string.Format(BasicNotificationFormat, AsStringLiteral(method), paramsContent);
_writer.WriteLine(message);
_writer.Flush();
}

private static string AsStringLiteral(string input) => $"\"{input}\"";
Loading