http-client-java, bug fix, parameter name mismatch in op and in convenienceApi #6162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ody" This reverts commit 516a8b6.
microsoft-github-policy-service
bot
added
the
emitter:client:java
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
|
You can try these changes here
|
...a/com/microsoft/typespec/http/client/generator/core/preprocessor/tranformer/Transformer.java
Show resolved
Hide resolved
...e/src/main/java/com/microsoft/typespec/http/client/generator/core/util/ModelExampleUtil.java
Show resolved
Hide resolved
weidongxu-microsoft
requested review from
srnagar,
haolingdong-msft and
XiaofeiCao
as code owners
XiaofeiCao
approved these changes
Feb 27, 2025
weidongxu-microsoft
deleted the
http-client-java_fix-example-node-payload-flatten
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxpagesizeget renamed to client namemaxPageSize, but param in convenienceApi was not renamed. This causes NPE when matching the parameters.Also add a protection in example generation code (with a warning), so even in case there is problem, it won't crash there.
PR include some update to diagnostic, that now it includes all stack/stdout/stderr, as I found it easier to get all the information without re-run the whole process -- which may not be controlled by us.
autorest.java Azure/autorest.java#3032