Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes repo build issues when running on Windows #6171

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

chrisradek
Copy link
Member

Building the website and running e2e tests were failing when ran on windows for 2 reasons:

  1. Changes to more recent versions of node.js when spawning processes
  2. Issues with path resolution

1 was solved by using cross-spawn
2 was solved by using pathe instead of path/posix

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 27, 2025

All changed packages have been documented.

  • @typespec/compiler
  • @typespec/internal-build-utils
Show changes

@typespec/compiler - internal ✏️

Adds test and internal dependencies to fix Windows build issues

@typespec/internal-build-utils - internal ✏️

Adds test and internal dependencies to fix Windows build issues

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@chrisradek chrisradek added this pull request to the merge queue Feb 27, 2025
Merged via the queue into microsoft:main with commit 9d605f9 Feb 27, 2025
24 checks passed
@chrisradek chrisradek deleted the fix-windows-build branch February 27, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants