-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Not Ready] [typespec-vscode] Show emitter internal msg in tspconfig #6197
base: main
Are you sure you want to change the base?
[Not Ready] [typespec-vscode] Show emitter internal msg in tspconfig #6197
Conversation
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
You can try these changes here
|
const sourceFile = await serverHost.compilerHost.readFile(configFilePath); | ||
const emitterName = err.info.metadata.name; | ||
const lineAndChar = sourceFile.getLineAndCharacterOfPosition( | ||
sourceFile.text.indexOf(emitterName), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we use yaml to load the doc and get the pos? indexof may not return the right string if user has that text in other places
Fix:#5761
Mark emitter internal errors in diagnostics to the
tspconfig.yaml
file