get entrypoint file #6200
Open
get entrypoint file #6200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verseEntrypointFile
chunyu3
requested review from
RodgeFu,
bterlson,
markcowl,
allenjzhang,
timotheeguerin,
chrisradek and
AlitzelMendez
as code owners
|
All changed packages have been documented.
|
|
You can try these changes here
|
…verseEntrypointFile
chunyu3
force-pushed
the
TraverseEntrypointFile
branch
from
134de2b to
e0065d9
Compare
timotheeguerin
requested changes
Feb 28, 2025
| return entrypointTspFiles; | ||
| } | ||
|
|
||
| async function getEntrypointTspFileInFolder(folder: string): Promise<string | undefined> { |
There was a problem hiding this comment.
you shouldn't rewrite that this is not the actual logic, you are missing exports which are a very complex resolution
We should share this logic from the compiler
There was a problem hiding this comment.
Can you document what gets resolved here?
Does it now only look for a pacakge.json first and then a main.tsp or it just look up for the first it finds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the entrypoint file from a tsp project step by step as following:
tspMaindefined inpackage.json, return the value oftspMainmain.tspApply above entrypoint strategy to traverse all entrypoint files in vscode worksapces.