Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add spector test for jsonl #6201

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

add spector test for jsonl #6201

wants to merge 2 commits into from
+68 −0

Conversation

tadelesh
Copy link
Member

No description provided.

@microsoft-github-policy-service microsoft-github-policy-service bot added the lib:http-specs For issues/prs related to the @typespec/http-specs package label Feb 28, 2025
@tadelesh
Copy link
Member Author

when regen doc for spector, i encountered this error. @timotheeguerin is it a problem in spector or in http lib?
image

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 28, 2025 •
edited
Loading

❌ There is undocummented changes. Run chronus add to add a changeset or click here.

The following packages have changes but are not documented.

  • ❌@typespec/http-specs
Show changes

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

timotheeguerin
timotheeguerin reviewed Feb 28, 2025
View reviewed changes
packages/http-specs/specs/stream/jsonl/main.tsp

@doc("Test of jsonl stream.")
@scenarioService("/stream/jsonl")
namespace Stream.Jsonl;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when regen doc for spector, i encountered this error. @timotheeguerin is it a problem in spector or in http lib?
image

replying here so we can have a thread. I think this is the same problem the Azure specs have where the namespace conflict with an existing namespace from a library and we add to add _Specs_ prefix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin left review comments

@bterlson bterlson Awaiting requested review from bterlson bterlson will be requested when the pull request is marked ready for review bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl will be requested when the pull request is marked ready for review markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang will be requested when the pull request is marked ready for review allenjzhang is a code owner

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft will be requested when the pull request is marked ready for review witemple-msft is a code owner

@chrisradek chrisradek Awaiting requested review from chrisradek chrisradek will be requested when the pull request is marked ready for review chrisradek is a code owner

@AlitzelMendez AlitzelMendez Awaiting requested review from AlitzelMendez AlitzelMendez will be requested when the pull request is marked ready for review AlitzelMendez is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
lib:http-specs For issues/prs related to the @typespec/http-specs package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tadelesh @azure-sdk @timotheeguerin