-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add spector test for jsonl #6201
base: main
Are you sure you want to change the base?
Conversation
when regen doc for spector, i encountered this error. @timotheeguerin is it a problem in spector or in http lib? |
You can try these changes here
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the "pass" criteria for the test :-)
For the simple version, it would just be binary of such input/output to/from the API?
i think so. currently, we could only need to support send request or receive response with binary payload. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit for the location.
We currently had a payload
folder and response
folder. But this test contains both. I would be fine that we add the streaming
folder.
headers: { | ||
"Content-Type": "application/jsonl", | ||
}, | ||
body: '{"desc": "one"}\n{"desc": "two"}\n{"desc": "three"}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: '{"desc": "one"}\n{"desc": "two"}\n{"desc": "three"}'
appears for 3 times so maybe you could define a constant variable to reuse it.
@timotheeguerin could you help to review? i did not add full support of streaming for spector, just add make sure jsonl could be tested with binary send/receive way. |
No description provided.