http-client-java, fix corner case that reserved keyword renamed differently #6218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:java
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
|
You can try these changes here
|
weidongxu-microsoft
requested review from
srnagar,
haolingdong-msft and
XiaofeiCao
as code owners
|
Wonder what's the corner case here. Would you help add a test case? |
weidongxu-microsoft
changed the title
Test added e1efcb4 The failure in nightly build was casued by the |
XiaofeiCao
approved these changes
Mar 4, 2025
weidongxu-microsoft
added a commit
to Azure/autorest.java
that referenced
this pull request
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On param,
floatbe renamedfloatParameter, while on model property, it be renamedfloatProperty.The old mapping logic in ClientMethodMapper failed to handle this corner case.
Add a fallback logic in
ClientMethodMapper.Also updated
Transformer, to rename properties forGroupSchemadifferently (as it groups method parameters).autorest.java Azure/autorest.java#3034