Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download configured package manager and run it #6220

Merged
merged 29 commits into from
Mar 7, 2025

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Mar 3, 2025

fix #5687

Features

  • respect the packageManager(Format <packageManager>@<version> or <packageManager>@<version>+<algo>.<hash>) and devEngines.packageManager field
  • packages are be downloaded from the public npm registry
    -no support yet for proxy, private registries, using the node route is always available for those cases
  • ability to save a hash of the packagemanager in the field which is used to validate the .tgz file match.
  • new flag --save-package-manager which populate the packageManager field with the resolved version and the hash.

Only support npm for now. Adding support for yarn and pnpm should be quite simple.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 3, 2025

All changed packages have been documented.

  • @typespec/compiler
Show changes

@typespec/compiler - feature ✏️

tsp install now downloads and uses the configured package manager in devEngines.packageManager or packageManager field of package.json

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 3, 2025

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@timotheeguerin timotheeguerin changed the title Pm download Download configured package manager and run it Mar 5, 2025
@timotheeguerin timotheeguerin added this pull request to the merge queue Mar 6, 2025
@timotheeguerin timotheeguerin removed this pull request from the merge queue due to a manual request Mar 6, 2025
@timotheeguerin timotheeguerin enabled auto-merge March 6, 2025 21:47
@timotheeguerin timotheeguerin added this pull request to the merge queue Mar 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2025
@timotheeguerin timotheeguerin enabled auto-merge March 6, 2025 23:39
@timotheeguerin timotheeguerin added this pull request to the merge queue Mar 7, 2025
Merged via the queue into microsoft:main with commit 3fb34c1 Mar 7, 2025
23 checks passed
@timotheeguerin timotheeguerin deleted the pm-download branch March 7, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tsp install should download package manager and use version configured by user
5 participants