[python] support continuation token for paging #6242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hon-tcgc-0.51.3
…hon-tcgc-0.51.3
msyyc
requested review from
iscai-msft,
tadelesh,
timotheeguerin and
lmazuel
as code owners
microsoft-github-policy-service
bot
added
the
emitter:client:python
|
All changed packages have been documented.
|
|
You can try these changes here
|
msyyc
changed the title
msyyc
changed the title
tadelesh
reviewed
Mar 7, 2025
Comment on lines
+102
to
+110
| if (segments.length > 0 && segments[0].kind === "property") { | ||
| const result = []; | ||
| for (const segment of segments) { | ||
| if (segment.kind === "property") { | ||
| result.push(segment.serializationOptions.json?.name ?? ""); | ||
| } | ||
| } | ||
| return result.join("."); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (segments.length > 0 && segments[0].kind === "property") { | |
| const result = []; | |
| for (const segment of segments) { | |
| if (segment.kind === "property") { | |
| result.push(segment.serializationOptions.json?.name ?? ""); | |
| } | |
| } | |
| return result.join("."); | |
| } | |
| if (segments[0]?.kind === "property") { | |
| return segments.filter(s=>s.kind === "property").map(s=>s.serializationOptions.json?.name ?? "").join("."); | |
| } |
Comment on lines
+115
to
+116
| if self.is_continuation_token: | ||
| return f"{self.client_name} if _next_token is _Unset else _next_token" |
There was a problem hiding this comment.
if we do not need _Unset as i mentioned in the generated code change pr, then we do not need this is_continuation_token, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5791
API design: https://gist.github.com/msyyc/02463a6dc5a150772bd8f0ae42d4cd37
Summary for this PR:
isContinuationTokenin parameterContinuationTokenRequest/ContinuationTokenResponsefor paging operation whose type is{wireName: string, position: "header" | "query" | "body"}isContinuationToken/ContinuationTokenRequest/ContinuationTokenResponse, it is much easier for pygen to generate related APIcontinuationTokenNamewhich is actually used as withnextLinkNamewithnextLinkName