Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The deploy icon appears only the first time changes are saved when using the "Edit Container Apps (Advanced)" option #841

Open
Amar-QA opened this issue Jan 15, 2025 · 1 comment
Labels
AT-CTI bug Something isn't working

Comments

@Amar-QA
Copy link

Amar-QA commented Jan 15, 2025

OS: All
Build: v0.7.2-alpha.0
Regression: Not a Regression

Repro Steps:

  1. Expand a container app environment -> Right click a container app -> Click "Edit Container App (Advanced)...".
  2. Edit the value of Environment Variable -> Save the changes.
  3. Deploy the changes to the container app by clicking the deploy icon.
  4. Verify that the changes have been deployed to the environment variable.
  5. Edit again the value of Environment Variable -> Save the changes.
  6. Check whether the deploy icon appears again.

Expect:
The deploy icon appears again.
Image

Actual:
The deploy icon doesn't appear.
Image

More Info:

  1. Refresh can't fix this issue.
  2. The deploy icon will appear again after reloading the JSON file and saving the changes.
@Amar-QA Amar-QA added the AT-CTI label Jan 15, 2025
@motm32 motm32 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2025
@motm32 motm32 reopened this Jan 15, 2025
@motm32 motm32 added the bug Something isn't working label Jan 15, 2025
@MicroFish91
Copy link
Contributor

MicroFish91 commented Jan 17, 2025

Ahh I see, the json envelope is stale after the deployment. Good news is, it doesn't make any active changes to the container app, which makes sense why it's not detecting unsaved changes. I personally think it's not worth the effort to try to design around this since a user can simply close and reopen the json after the new deployment has been made. I'll throw in backlog candidates to see if people want this enhancement.

@MicroFish91 MicroFish91 added this to the Backlog Candidates milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT-CTI bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants